test: add coverage for dgram _createSocketHandle() #11291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Feb 10, 2017
cjihrig
force-pushed
the
create-socket-handle
branch
3 times, most recently
from
7896f47
to
1da95a0
Compare
This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets. PR-URL: nodejs#11291 Reviewed-By: James M Snell <[email protected]>
cjihrig
force-pushed
the
create-socket-handle
branch
from
1da95a0
to
a2fac32
Compare
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets. PR-URL: nodejs#11291 Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets. PR-URL: #11291 Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets. PR-URL: #11291 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets. PR-URL: #11291 Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets. PR-URL: #11291 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code coverage to
_createSocketHandle(), which theclustermodule uses to create dgram sockets.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test